Fixed issue where not only some of the beam file would be read by the

input stream, giving an incomplete beam.

Author: Andy Till

src/main/java/erlyberly/node/NodeAPI.java

@@ -10,6 +10,7 @@
 import java.io.InputStream;
 import java.time.LocalDateTime;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.concurrent.atomic.AtomicBoolean;
 
@@ -151,11 +152,13 @@ public void run() {
 
 	private void loadRemoteErlyberly() throws IOException, OtpErlangException {
 
-		sendRPC("code", "load_binary",
+		OtpErlangBinary otpErlangBinary = new OtpErlangBinary(loadBeamFile());
+		System.out.println("binary size=" + otpErlangBinary.size());
+        sendRPC("code", "load_binary",
 				list(
 						atom("erlyberly"),
 						new OtpErlangString(ERLYBERLY_BEAM_PATH),
-						new OtpErlangBinary(loadBeamFile())));
+						otpErlangBinary));
 
 		OtpErlangObject result = receiveRPC();
 
@@ -186,14 +189,21 @@ private OtpErlangObject receiveRPC() throws IOException, OtpErlangException {
 
 	private static byte[] loadBeamFile() throws IOException {
 		InputStream resourceAsStream = OtpUtil.class.getResourceAsStream(ERLYBERLY_BEAM_PATH);
+		
 		byte[] b = new byte[BEAM_SIZE_LIMIT];
-		int read = resourceAsStream.read(b);
-
-		if(read >= BEAM_SIZE_LIMIT) {
+		int total = 0;
+		int read = 0;
+		
+		do {
+            total += read;
+		    read = resourceAsStream.read(b, total, BEAM_SIZE_LIMIT - total);
+		} while (read != -1);
+
+		if(total >= BEAM_SIZE_LIMIT) {
 			throw new RuntimeException("erlyberly.beam file is too big");
 		}
-
-		return b;
+		
+		return Arrays.copyOf(b, total);
 	}
 
 	public synchronized void retrieveProcessInfo(ArrayList<ProcInfo> processes) throws Exception {

src/main/resources/erlyberly/beam/erlyberly.beam

@@ -388,10 +388,6 @@ format_pid(Pid) when is_pid(Pid) ->
 format_pid(Port) when is_port(Port) ->
     erlang:port_to_list(Port).
 
-%%
-log_seq_trace(Seq_trace) ->
-    io:format("~s ~p~n", [format_utc_timestamp(), Seq_trace]).
-
 %%
 format_utc_timestamp() ->
     TS = {_,_,Micro} = os:timestamp(),