-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ImageViewer): 底层图片渲染使用 Image #5790
base: master
Are you sure you want to change the base?
Conversation
可以在 |
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-5790.surge.sh |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5790 +/- ##
==========================================
- Coverage 90.90% 89.61% -1.30%
==========================================
Files 305 297 -8
Lines 6607 6392 -215
Branches 1635 1579 -56
==========================================
- Hits 6006 5728 -278
- Misses 556 612 +56
- Partials 45 52 +7
☔ View full report in Codecov by Sentry. |
@miracles1919 大佬有空再看下吧~ |
#5765
@miracles1919 有几个不确定的点,麻烦神迹大佬看一下:
placeholder
要不要默认为空?(图片加载完成后会闪一下)max-width
max-height
使用了vw
vh
单位,否则图片无法自适应