Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popup): add closeOnSwipe prop #6203

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

miracles1919
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (671c077) 90.59% compared to head (03c0677) 90.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6203   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files         304      304           
  Lines        6592     6593    +1     
  Branches     1639     1640    +1     
=======================================
+ Hits         5972     5973    +1     
  Misses        568      568           
  Partials       52       52           
Impacted Files Coverage Δ
src/components/popup/popup.tsx 84.72% <100.00%> (+0.21%) ⬆️
src/utils/reduce-and-restore-motion.ts 95.65% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6203.surge.sh

@miracles1919 miracles1919 changed the title feat(Popup): add enableSwipeToClose prop feat(Popup): add closeOnSwipe prop Jun 12, 2023
@zombieJ zombieJ merged commit 4be09f6 into ant-design:master Jun 12, 2023
@miracles1919 miracles1919 deleted the feat/popup branch June 12, 2023 07:06
@Da-Sheng
Copy link
Contributor

this props not exist in now version, but the doc still exist
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants