enhance: 避免因优先级导致css变量无法生效 #6649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6649 +/- ##
==========================================
+ Coverage 92.34% 92.60% +0.26%
==========================================
Files 318 327 +9
Lines 6910 7034 +124
Branches 1729 1762 +33
==========================================
+ Hits 6381 6514 +133
+ Misses 493 484 -9
Partials 36 36 ☔ View full report in Codecov by Sentry. |
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6649.surge.sh |
zombieJ
reviewed
Jun 24, 2024
src/components/nav-bar/nav-bar.less
Outdated
| display: flex; | ||
| align-items: center; | ||
| height: var(--height); | ||
| border-bottom: var(--border-bottom); | ||
| height: var(--height, 45px); |
There was a problem hiding this comment.
其他地方也会用到 --height 变量，之前的写法可以用来阻断继承。这么改会break掉。如果要解决 tailwind 优先级问题，应该是通过 @layer 引入 antd-mobile 的 css 让其优先级始终低于 tailwind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如图，tailwindcss 生成的样式表优先级低于页面样式