Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unnecessary --save flag from npm install command #6667

Closed

Conversation

ChuYang-FE
Copy link
Contributor

What does this PR do?

Since npm version 5.0.0, the --save flag is no longer required.

This PR updates the README.md file to remove the unnecessary --save flag from the npm install command.

npm version

Why is this important?

Removing the --save flag makes the documentation cleaner and prevents potential confusion for users who might think the flag is still necessary. This change helps keep the documentation up-to-date with the current npm behavior.

Changes made:

  • Removed --save flag from the npm install command in the README.md file.

Related issues:

  • None

Additional notes:

  • Tested the updated command to ensure it works as expected with the latest npm version.

…ADME.md

Since npm version 5.0.0, the `--save` flag is no longer required as npm automatically adds the installed package to `dependencies` in the `package.json` file.

This commit updates the README.md to reflect this change, making the documentation cleaner and more accurate.
Copy link
Contributor

github-actions bot commented Jul 8, 2024

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6667.surge.sh

@zombieJ
Copy link
Member

zombieJ commented Jul 8, 2024

Strange, CI failed but I'm sure it's not related with this PR. Wait and retry later...

@ChuYang-FE
Copy link
Contributor Author

Strange, CI failed but I'm sure it's not related with this PR. Wait and retry later...

In this PR (#6664), he has pushed a new commit to fix this issue, could you please check? Thanks!

image

keqingrong and others added 2 commits July 9, 2024 14:35
* feat(DatePicker): add quarter precision

* test(DatePicker): add test case for quarter precision

* chore: upgrade pnpm/action-setup to v4 to prevent ci failures

---------

Co-authored-by: Ke Qingrong <[email protected]>
@ChuYang-FE
Copy link
Contributor Author

close this PR and created a new one #6669

@ChuYang-FE ChuYang-FE closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants