feat(TabBar): add onClick props to the TabBar.Item #6702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6702.surge.sh |
zombieJ
reviewed
Aug 7, 2024
|
Oh god, THANK YOU |
zombieJ
reviewed
Aug 7, 2024
| @@ -1,5 +1,5 @@ | |||
| import React, { useState } from 'react' | |||
| import { Badge, TabBar } from 'antd-mobile' | |||
| import { Badge, TabBar, Toast } from 'antd-mobile' | |||
zombieJ
reviewed
Aug 7, 2024
src/components/tab-bar/index.en.md
Outdated
| @@ -33,6 +33,7 @@ Useful for switching between different pages. | |||
| | icon | Icon | `ReactNode \| ((active: boolean) => ReactNode)` | - | | |||
| | key | Corresponding to `activeKey` | `string` | - | | |||
| | title | Title | `ReactNode \| ((active: boolean) => ReactNode)` | - | | |||
| | onClick | Callback when click item | `(key: string) => void` | - | | |||
zombieJ
reviewed
Aug 7, 2024
src/components/tab-bar/tab-bar.tsx
Outdated
| @@ -12,6 +12,7 @@ export type TabBarItemProps = { | |||
| icon?: ReactNode | ((active: boolean) => ReactNode) | |||
| title?: ReactNode | ((active: boolean) => ReactNode) | |||
| badge?: BadgeProps['content'] | |||
| onClick?: (key: string) => void | |||
There was a problem hiding this comment.
item 里的点击不需要给 key，因为事件本身就是在对应的 item 上的。直接是 VoidFunction 即可
zombieJ
approved these changes
Aug 7, 2024
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #6701