Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feat manual tigger PullToRefresh #6490

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

day-xue
Copy link
Contributor

@day-xue day-xue commented Dec 20, 2023

#6464 提供手动触发refresh 能力 文档也已补充


| 属性 | 说明 | 类型 |
| --------- | ---------------- | ---------- |
| doRefresh | 手动触发下拉刷新 | `()=>void` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refresh 吧,本身就是动词,不需要 do 了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refresh 吧,本身就是动词,不需要 do 了

好的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refresh 吧,本身就是动词,不需要 do 了

已修改

@zombieJ
Copy link
Member

zombieJ commented Dec 20, 2023

对了,基线记得改成 feature 哈~

@day-xue
Copy link
Contributor Author

day-xue commented Dec 20, 2023

对了,基线记得改成 feature 哈~

抱歉 第一次提pr 基线在哪里改

@afc163
Copy link
Member

afc163 commented Dec 20, 2023

图片

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8746e07) 92.25% compared to head (8518c21) 92.20%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/components/pull-to-refresh/pull-to-refresh.tsx 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6490      +/-   ##
==========================================
- Coverage   92.25%   92.20%   -0.06%     
==========================================
  Files         316      316              
  Lines        6873     6880       +7     
  Branches     1723     1724       +1     
==========================================
+ Hits         6341     6344       +3     
- Misses        496      500       +4     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6490.surge.sh

@day-xue day-xue changed the base branch from master to feature December 20, 2023 09:24
@zombieJ
Copy link
Member

zombieJ commented Dec 20, 2023

重新 merge 一下 feature,我更新了一下~

@day-xue
Copy link
Contributor Author

day-xue commented Dec 25, 2023

重新 merge 一下 feature,我更新了一下~

是重新发一个pr吗?

@zombieJ
Copy link
Member

zombieJ commented Jan 3, 2024

就是 CI 挂了,重新 merge 一下 feature 就行了。不是开新的 PR

@j-joker
Copy link

j-joker commented Jun 20, 2024

any update on this pr

@j-joker
Copy link

j-joker commented Jul 26, 2024

@day-xue 可以看看这个pr吗宝贝

@day-xue
Copy link
Contributor Author

day-xue commented Jul 26, 2024

@day-xue 可以看看这个pr吗宝贝

你好 怎么了

@j-joker
Copy link

j-joker commented Jul 26, 2024

@day-xue 可以看看这个pr吗宝贝

你好 怎么了

刚好需要这个能力,我看这个pr应该是只要merge下基线分支就可以合了?

@day-xue day-xue changed the base branch from feature to master July 26, 2024 04:17
@sunjinshuai
Copy link

这个 PR 还没有合入吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants