Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal组件反馈 #309

Open
RyanLiu0235 opened this issue Jan 10, 2020 · 0 comments
Open

Modal组件反馈 #309

RyanLiu0235 opened this issue Jan 10, 2020 · 0 comments

Comments

@RyanLiu0235
Copy link

版本:0.4.34

问题:

  1. 弹窗不是自动垂直水平居中。
  2. 底部只能设置一个按钮,就算自己设置了两个,回调函数也没有合适的入参来让开发者区分到底是按了哪个按钮。
  3. props设计不规范,很多地方引用但是不声明,导致外面传参的时候一直warning,开发体验不友好。

说到底这个组件库是开发出来给三方用的,如果说第一个出于某些不可知的考量不做的,第三个是忘记了,那么第二个的确无法理解了,下面两个按钮的操作不是很常见么?

当然,第二个我也可以自己手动覆盖样式+自己绑定事件,但是那我就不如自己写一个了。

算了,我还是自己写一个吧。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant