Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] doc: Datatype in some catalog doc should be correct #4956

Closed
danhuawang opened this issue Sep 18, 2024 · 4 comments · Fixed by #5039
Closed

[Bug report] doc: Datatype in some catalog doc should be correct #4956

danhuawang opened this issue Sep 18, 2024 · 4 comments · Fixed by #5039
Assignees
@lsyulong
Labels
0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 bug Something isn't working

Comments

@danhuawang
Copy link
Contributor

Version

main branch

Describe what's wrong

Gravitino support column type is listed in this page: https://gravitino.apache.org/docs/0.6.0-incubating/manage-relational-metadata-using-gravitino#apache-gravitino-table-column-type
In this column type table, there's only 'List' Datatype ,but in gravitino support catalog doc, some appear as 'Array',some appear as 'List'. It should be consistent.
image

In catalog page:
https://gravitino.apache.org/docs/0.6.0-incubating/lakehouse-iceberg-catalog/#table-column-types
image

https://gravitino.apache.org/docs/0.6.0-incubating/apache-hive-catalog/#table-column-types
image

image

https://gravitino.apache.org/docs/0.6.0-incubating/lakehouse-paimon-catalog/#table-column-types
image

Error message and/or stacktrace

N/A

How to reproduce

N/A

Additional context

No response
@danhuawang danhuawang added the bug Something isn't working label Sep 18, 2024
@jerryshao
Copy link
Contributor

@mchades would you please help to check this?

@lsyulong
Copy link
Contributor

Hello, can I come and take a look at this question? I will communicate with you if there are any further questions

@jerryshao
Copy link
Contributor

Sure, please go ahead, if you have further question, you can leave message here, or ping @mchades .

@lsyulong lsyulong mentioned this issue Sep 28, 2024
Merged
@lsyulong
Copy link
Contributor

Sure, please go ahead, if you have further question, you can leave message here, or ping @mchades .

Hello, I have modified the corresponding data type mapping in the document. Please check if there are any issues on your end

@mchades mchades added 0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 labels Sep 29, 2024
github-actions bot pushed a commit that referenced this issue Sep 29, 2024
@lsyulong @web-flow
[#4956] fix(docs): Correct array and union and struct mapping documen…
8b51c5a 
…t for Gravitino (#5039)

### What changes were proposed in this pull request?
Fix the data type mapping in some catalog doc

### Why are the changes needed?

Datatype in some catalog doc should be correct

Fix: #4956
@github-actions github-actions bot mentioned this issue Sep 29, 2024
Merged
jerryshao pushed a commit that referenced this issue Sep 29, 2024
@github-actions @lsyulong
[#4956] fix(docs): Correct array and union and struct mapping documen…
a0dee14 
…t for Gravitino (#5041)

### What changes were proposed in this pull request?
Fix the data type mapping in some catalog doc

### Why are the changes needed?

Datatype in some catalog doc should be correct

Fix: #4956

Co-authored-by: lsyulong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsyulong lsyulong

Labels
0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@jerryshao @mchades @lsyulong @danhuawang