Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Unify the modification behavior of the comment field. #4968

Open
mchades opened this issue Sep 20, 2024 · 0 comments
Open

[Improvement] Unify the modification behavior of the comment field. #4968

mchades opened this issue Sep 20, 2024 · 0 comments
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@mchades
Copy link
Contributor

mchades commented Sep 20, 2024

What would you like to be improved?

Currently, only the fileset supports the removeComment change; other entities like catalog and table only support updateComment changes. Additionally, newComment cannot be null or an empty string. We should unify this behavior.

How should we improve?

Unify the modification behavior of the comment field：

  • deprecated the removeComment change
  • the new comment of updateComment supports null and empty string
@mchades mchades added improvement Improvements on everything good first issue Good for newcomers labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mchades