Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Issue with PathBasedMetadataObject.java toString method #6235

Open
justinmclean opened this issue Jan 15, 2025 · 1 comment · May be fixed by #6252
Open

[Improvement] Issue with PathBasedMetadataObject.java toString method #6235

justinmclean opened this issue Jan 15, 2025 · 1 comment · May be fixed by #6252
Assignees
@Abyss-lord
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

The + operator has a higher precedence than the == operator, as a result, the expression "path=" + path == null will always be evaluated to false.

How should we improve?

Change the code to work as intended
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Jan 15, 2025
@Abyss-lord
Copy link
Contributor

I would like to work on it.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 15, 2025
@Abyss-lord
[apache#6235] improvement(authorizations): fix PathBasedMetadataObjec…
03cd2f2 
…t.java toString method

fix toString method.
@Abyss-lord Abyss-lord linked a pull request Jan 15, 2025 that will close this issue
Open
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 16, 2025
@Abyss-lord
[apache#6235] improvement(authorizations): fix PathBasedMetadataObjec…
1780dc1 
…t.java toString method

fix some issues.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Jan 16, 2025
@Abyss-lord
[apache#6235] improvement(authorizations): fix PathBasedMetadataObjec…
71a3c1f 
…t.java toString method

add catch expression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6235] fix(authz): fix PathBasedMetadataObject toString method Abyss-lord/gravitino
2 participants
@justinmclean @Abyss-lord