diff --git a/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LayeredOptions.java b/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LayeredOptions.java index 4d9d7b6c09e..2f9c367c478 100644 --- a/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LayeredOptions.java +++ b/impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LayeredOptions.java @@ -181,7 +181,9 @@ protected Optional> collectMapIfPresentOrEmpty( Optional> up = getter.apply(option); if (up.isPresent()) { had++; - items.putAll(up.get()); + for (Map.Entry entry : up.get().entrySet()) { + items.putIfAbsent(entry.getKey(), entry.getValue()); + } } } return had == 0 ? Optional.empty() : Optional.of(Map.copyOf(items)); diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng8594AtFileTest.java b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng8594AtFileTest.java new file mode 100644 index 00000000000..a0ad34011e0 --- /dev/null +++ b/its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng8594AtFileTest.java @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.it; + +import java.nio.file.Path; +import java.util.List; + +import org.junit.jupiter.api.Test; + +import static org.junit.Assert.assertTrue; + +/** + * This is a test set for MNG-8594. + */ +class MavenITmng8594AtFileTest extends AbstractMavenIntegrationTestCase { + + MavenITmng8594AtFileTest() { + super("[4.0.0-rc-3-SNAPSHOT,)"); + } + + /** + * Verify Maven picks up params/goals from atFile. + */ + @Test + void testIt() throws Exception { + Path basedir = extractResources("/mng-8594").getAbsoluteFile().toPath(); + + Verifier verifier = newVerifier(basedir.toString()); + verifier.addCliArgument("-af"); + verifier.addCliArgument("cmd.txt"); + verifier.addCliArgument("-Dcolor1=green"); + verifier.addCliArgument("-Dcolor2=blue"); + verifier.addCliArgument("clean"); + verifier.execute(); + verifier.verifyErrorFreeLog(); + + // clean did run + verifier.verifyTextInLog("(default-clean) @ root"); + // validate bound plugin did run + verifier.verifyTextInLog("(eval) @ root"); + + // validate properties + List properties = verifier.loadLines("target/pom.properties"); + assertTrue(properties.contains("session.executionProperties.color1=green")); // CLI only + assertTrue(properties.contains("session.executionProperties.color2=blue")); // both + assertTrue(properties.contains("session.executionProperties.color3=yellow")); // cmd.txt only + } +} diff --git a/its/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java b/its/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java index a303f19ca3d..101ddd853ea 100644 --- a/its/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java +++ b/its/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java @@ -100,6 +100,7 @@ public TestSuiteOrdering() { * the tests are to finishing. Newer tests are also more likely to fail, so this is * a fail fast technique as well. */ + suite.addTestSuite(MavenITmng8594AtFileTest.class); suite.addTestSuite(MavenITmng8561SourceRootTest.class); suite.addTestSuite(MavenITmng8523ModelPropertiesTest.class); suite.addTestSuite(MavenITmng8527ConsumerPomTest.class); diff --git a/its/core-it-suite/src/test/resources/mng-8594/cmd.txt b/its/core-it-suite/src/test/resources/mng-8594/cmd.txt new file mode 100644 index 00000000000..2d638e72a64 --- /dev/null +++ b/its/core-it-suite/src/test/resources/mng-8594/cmd.txt @@ -0,0 +1,3 @@ +validate +-Dcolor2=gray +-Dcolor3=yellow \ No newline at end of file diff --git a/its/core-it-suite/src/test/resources/mng-8594/pom.xml b/its/core-it-suite/src/test/resources/mng-8594/pom.xml new file mode 100644 index 00000000000..fa94de4747b --- /dev/null +++ b/its/core-it-suite/src/test/resources/mng-8594/pom.xml @@ -0,0 +1,34 @@ + + + + 4.0.0 + + org.apache.maven.it.mng8594 + root + 1.0.0 + + + + + org.apache.maven.its.plugins + maven-it-plugin-expression + 2.1-SNAPSHOT + + target/pom.properties + + session/executionProperties + + + + + eval + + eval + + validate + + + + + +