Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Javadoc cleanup #2126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor Javadoc cleanup #2126

wants to merge 1 commit into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 25, 2025

No description provided.

@cstamas
Copy link
Member

cstamas commented Feb 25, 2025

You are aware you are editing compat subproject? You know, a subproject that should be left as is (ie. "frozen") and is there only for backward compatibility reasons?

@elharo
Copy link
Contributor Author

elharo commented Feb 25, 2025

I'm only editing the Javadoc here, and that can certainly be improved. It is a little annoying that version comparison now exists in multiple places and repos.

https://xkcd.com/927/

@elharo elharo marked this pull request as ready for review February 25, 2025 21:44
@elharo
Copy link
Contributor Author

elharo commented Feb 25, 2025

Also worth noting: ComparableVersion is public API used by code that is not in Maven and not part of a Maven plugin. We should not just abandon it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants