[MNG-8594] Add atFile option #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where user can create ad-hoc command line parms. The difference between .mvn/maven.conf and this file is that this file allws goals as well. The CLI and atFile are merged, in this order, hence, goals in atFile will come AFTER goals specified on CLI. --- https://issues.apache.org/jira/browse/MNG-8594
|
Looks good, that can be handy ! |
|
@gnodet Added IT, that revealed precedence issue in case of User Properties ( |
cstamas
commented
Feb 26, 2025
| @@ -181,7 +181,9 @@ protected Optional<Map<String, String>> collectMapIfPresentOrEmpty( | |||
| Optional<Map<String, String>> up = getter.apply(option); | |||
| if (up.isPresent()) { | |||
| had++; | |||
| items.putAll(up.get()); | |||
There was a problem hiding this comment.
It was putAll, meaning property coming from lower precedence (they are in-order), overwrote already present (higher precedence) property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where user can create ad-hoc command line parms. The difference between .mvn/maven.conf and this file is that this file allows goals as well. The CLI and atFile are merged, in this order, hence, goals in atFile will come AFTER goals specified on CLI, if CLI has them.
Source order (first wins for options, while goals are collected/aggregated from sources):
Note: option is called
afor longat-filefor similarity withjavac @file, but commons CLI does not support options without leading hyphen.https://issues.apache.org/jira/browse/MNG-8594