[SPARK-51302][CONNECT] Spark Connect supports JDBC should use the DataFrameReader API #50059
+13
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
force-pushed
the
SPARK-51302
branch
from
93a73e2 to
5d89a74
Compare
beliefer
changed the title
There was a problem hiding this comment.
Do you think you can add some test cases, @beliefer , to be clear what was the problem and to prevent a future regression?
Spark Connect already have the test cases. This improvement is just to unify the code path and improve the maintenance. |
LuciferYang
reviewed
Feb 25, 2025
| LogicalRelation(relation) | ||
| val properties = new Properties() | ||
| properties.putAll(rel.getDataSource.getOptionsMap) | ||
| reader.jdbc(url, table, predicates, properties).queryExecution.analyzed |
There was a problem hiding this comment.
When rel.getDataSource.getFormat == "jdbc" && rel.getDataSource.getPredicatesCount == 0 is true, isn't it unnecessary to use reader.jdbc(url, table, predicates, properties).queryExecution.analyzed?
There was a problem hiding this comment.
Yes. reader.load() could support that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to unify the calling to the
DataFrameReaderAPI in Spark Connect where supports the jdbc API.Why are the changes needed?
The origin code is good at a little advance of performance, but it is bad if we change the logic of jdbc API.
I think we should unify the code path here.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.