Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51303] [SQL] [TESTS] Extend ORDER BY testing coverage #50069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mihailoale-db
Copy link
Contributor

@mihailoale-db mihailoale-db commented Feb 24, 2025

What changes were proposed in this pull request?

I propose that we extend order-by-all.sql and DataFrameSuite.scala and add order-by.sql which extend the coverage of ORDER BY feature.

Why are the changes needed?

In order to catch potential bugs.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Added tests.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Feb 24, 2025
@mihailoale-db
Copy link
Contributor Author

@MaxGekk Could you PTAL when you have time? Thanks

@mihailoale-db mihailoale-db force-pushed the addorderbygoldenfiles branch 2 times, most recently from a1d0f07 to 580f7d3 Compare February 25, 2025 17:53
@vladimirg-db
Copy link
Contributor

Please address this: #50069 (comment)

@mihailoale-db mihailoale-db force-pushed the addorderbygoldenfiles branch 6 times, most recently from 1715fce to c2850b2 Compare February 26, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants