[SPARK-51289][SQL] Throw a proper error message for not fully implemented SQLTableFunction
#50073
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also cc @cloud-fan |
MaxGekk
reviewed
Feb 25, 2025
| @@ -34,8 +36,8 @@ object EliminateSQLFunctionNode extends Rule[LogicalPlan] { | |||
| plan.transformWithSubqueries { | |||
| case SQLFunctionNode(_, child) => child | |||
| case f: SQLTableFunction => | |||
| throw SparkException.internalError( | |||
| s"SQL table function plan should be rewritten during analysis: $f") | |||
| throw QueryCompilationErrors.tableValuedArgumentsNotYetImplementedForSqlFunctions( | |||
There was a problem hiding this comment.
Could you explain, please, why do we catch this in the optimizer, but not in the analyzer?
There was a problem hiding this comment.
Same question. How do we leak SQLTableFunction to the optimizer if we fail earlier in the analyzer/parser?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to throw a proper error message for not fully implemented
SQLTableFunction.Why are the changes needed?
Optimize error prompts for the new SQL user-defined functions feature.
Does this PR introduce any user-facing change?
No, this feature has not been released yet.
How was this patch tested?
Add a new test case and Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.