[SPARK-51323][PYTHON] Duplicate "total" on Py SQL metrics #50089
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianhillig-db
changed the title
|
LGTM (also could you please add a screenshot of the fixed issue as you did in the Jira desc if possible)? |
HyukjinKwon
approved these changes
Feb 27, 2025
HyukjinKwon
changed the title
|
Merged to master and branch-4.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 27, 2025
### What changes were proposed in this pull request? "total" is mentioned twice for PythonSQLMetrics. ### Why are the changes needed? Make metrics less confusing. ### Does this PR introduce _any_ user-facing change? Updates the metric presentation string. ### How was this patch tested? Existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50089 from sebastianhillig-db/duplicate-time-in-metrics. Authored-by: Sebastian Hillig <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 3ba50cd) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
"total" is mentioned twice for PythonSQLMetrics.
Why are the changes needed?
Make metrics less confusing.
Does this PR introduce any user-facing change?
Updates the metric presentation string.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.