[SPARK-51325] Check in source code for smallJar.jar
#50092
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dongjoon-hyun @vrozov Would a change like this where the source code is included be acceptable in keeping the JAR? |
|
Thank you for pining me. However, I would recommend to participate the dev mailing list before taking any actions on code, @vicennial . |
dongjoon-hyun
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Just FYI, this is all-or-nothing domain when it comes to the ASF source tar ball adheres to ASF policy or not, @vicennial .
LuciferYang
requested changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds source code to create
smallJar.jar. The jar is regenerated using the source provided and it's CRC is updated.Why are the changes needed?
To address concerns outlined in https://issues.apache.org/jira/browse/SPARK-51318 and https://lists.apache.org/thread/0ro5yn6lbbpmvmqp2px3s2pf7cwljlc4.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?