Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51326][CONNECT] Remove LazyExpression proto message #50093

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Feb 26, 2025

What changes were proposed in this pull request?

Removes LazyExpression proto message.

As any feature using this proto message is not released yet, it's safe to remove it from master and branch-4.0.

Why are the changes needed?

Discussed offline and found out that Spark Connect should work without it.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

The existing tests should pass.

Was this patch authored or co-authored using generative AI tooling?

No.

@ueshin
Copy link
Member Author

ueshin commented Feb 27, 2025

As "Protobuf breaking change detection and Python CodeGen check" failed with:

Error: Previously present message "LazyExpression" was deleted from file.
Error: Previously present field "22" with name "subquery_expression" on message "Expression" was deleted.
Error: Field "21" with name "subquery_expression" on message "Expression" changed option "json_name" from "lazyExpression" to "subqueryExpression".
Error: Field "21" with name "subquery_expression" on message "Expression" changed type from "spark.connect.LazyExpression" to "spark.connect.SubqueryExpression".
Error: Field "21" on message "Expression" changed name from "lazy_expression" to "subquery_expression".
Error: buf found 5 breaking changes.

#50094 should show it's not broken compared to 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants