Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When updating the dataset associated with an existing Handlebar chart, all the previous HTML and CSS gets lost #32049

Open
2 of 3 tasks
geido opened this issue Jan 30, 2025 · 2 comments
Labels
preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached. viz:charts:handlebars

Comments

@geido
Copy link
Member

geido commented Jan 30, 2025

Bug description

When you have an existing Handlebar chart with personalized HTML and CSS code, if you update the dataset that powers the chart, all the previous HTML and CSS get removed.

How to reproduce the bug

  1. Create a virtual dataset with something simple like select * from YourTable
  2. Create a handlebar chart with that dataset and add some HTML and CSS code in the customize section
  3. From the Chart section, click on the 3 dots on the left and “edit dataset”
  4. Change the query by adding a where clause or any other change you want.
  5. Save the dataset and click on “Update Chart”

Expected results

Your dataset gets updated and you have the same previous HTML and CSS applied to your handlebars chart

Actual results

Your dataset gets updated but all the previous HTML and CSS code you had gets lost. It also seems that the textarea "blinks" going back and forth between states.

Screenshots/recordings

Image

Superset version

master / latest-dev

Python version

3.9

Node version

18 or greater

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. labels Jan 30, 2025
@geido
Copy link
Member Author

geido commented Jan 30, 2025


🎉 Preset Bounty Available: $150 USD 🎉

To claim this bounty, please carefully follow the steps below.


📋 Steps to Participate

  1. Review Guidelines:
    Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

  2. Show Your Interest:
    Complete the Preset Bounty Program Survey and comment this issue to express your interest.

  3. Join the Slack Channel:
    After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

  4. Get Assigned:
    To officially start, ensure a Bounty Program Manager has assigned you to this issue.

  5. Submit Your Solution:
    When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

  6. Claim Your Bounty:
    Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/1056


💡 Additional Notes

  • Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
  • Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@DamianPendrak
Copy link
Contributor

Hi, could I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached. viz:charts:handlebars
Projects
None yet
Development

No branches or pull requests

3 participants
@DamianPendrak @geido and others