Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: security, user group support #32121

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Feb 3, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Feb 3, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 24, 2025
@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label Feb 24, 2025
@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 24, 2025
@github-actions github-actions bot removed the risk:db-migration PRs that require a DB migration label Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.47%. Comparing base (76d897e) to head (08857eb).
Report is 1488 commits behind head on master.

Files with missing lines Patch % Lines
superset/views/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32121       +/-   ##
===========================================
+ Coverage   60.48%   83.47%   +22.98%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39094    -37142     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32632    -13482     
+ Misses      28017     6462    -21555     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.53% <80.00%> (-0.64%) ⬇️
javascript ?
mysql 75.87% <90.00%> (?)
postgres 75.94% <90.00%> (?)
presto 53.05% <80.00%> (-0.75%) ⬇️
python 83.47% <90.00%> (+19.98%) ⬆️
sqlite 75.46% <90.00%> (?)
unit 61.11% <40.00%> (+3.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dpgaspar Processing your ephemeral environment request here. Action: up.

Copy link
Contributor

@dpgaspar Ephemeral environment spinning up at http://34.210.187.118:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants