From b07a141eb0db3cf53cb6674fb6c8557103016a93 Mon Sep 17 00:00:00 2001 From: Ethan Humphrey Date: Thu, 8 Aug 2024 11:17:26 -0400 Subject: [PATCH] Set _isNegative instead of negating --- .../Decimal/Decimal+Conformances.swift | 7 +++++-- Tests/FoundationEssentialsTests/DecimalTests.swift | 4 ++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Sources/FoundationEssentials/Decimal/Decimal+Conformances.swift b/Sources/FoundationEssentials/Decimal/Decimal+Conformances.swift index 7cc28217d..9f3131126 100644 --- a/Sources/FoundationEssentials/Decimal/Decimal+Conformances.swift +++ b/Sources/FoundationEssentials/Decimal/Decimal+Conformances.swift @@ -251,8 +251,11 @@ extension Decimal /* : FloatingPoint */ { self = .nan } } - if sign == .minus { - negate() + + guard self._length != 0 else { return } + _isNegative = switch sign { + case .plus: 0 + case .minus: 1 } } diff --git a/Tests/FoundationEssentialsTests/DecimalTests.swift b/Tests/FoundationEssentialsTests/DecimalTests.swift index b6c958f7d..db8b1d2e9 100644 --- a/Tests/FoundationEssentialsTests/DecimalTests.swift +++ b/Tests/FoundationEssentialsTests/DecimalTests.swift @@ -1130,9 +1130,9 @@ final class DecimalTests : XCTestCase { var x = -42 as Decimal XCTAssertEqual(x.significand.sign, .plus) var y = Decimal(sign: .plus, exponent: 0, significand: x) - XCTAssertEqual(y, -42) - y = Decimal(sign: .minus, exponent: 0, significand: x) XCTAssertEqual(y, 42) + y = Decimal(sign: .minus, exponent: 0, significand: x) + XCTAssertEqual(y, -42) x = 42 as Decimal XCTAssertEqual(x.significand.sign, .plus)