Migrate swift-foundation to swift-testing #908
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
All tests now pass in our CI, just waiting for confirmation that tests pass when run in the full toolchain suite before merging |
itingliu
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes to migrate swift-foundation to swift-testing. All swift-foundation tests have been fully migrated to swift-testing with this change. A few notes about the changes here:
expectEqual-like wrappers around XCTest and it no longer contains a list of type aliasesFoundationEssentialsTestsno longer linksFoundationInternationalization. As a result, some tests needed to be moved fromFoundationEssentialsTeststoFoundationInternationalizationTestsbecause they required having the i18n module loadedLocale/Calendar/TimeZone, and tests that did need to use these or other global state (like the CWD) were moved into nested serial suites (seeFilePlaygroundTestsas an example)