String+Path parsing performance improvements #927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved some String+Path functions' performance with the following changes:
.utf8
where applicable (such as when searching for asciiUInt8._slash
, which happens a lot).deletingPathComponent
didn't skip over consecutive trailing slashes.removingDotSegments
to directly modify the String bufferUInt8
arraysNon-implementation related:
var input
withutf8
to avoid confusionUInt8._dot
and._slash
instead of re-defining them in-functionResults: We generally see 2-6x speedup in the respective functions.
Old vs New
String
NSString
vsString