refactor: include/exclude dev deps in analyzers #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pom parser
DmitriyLewen
changed the title
|
@DmitriyLewen 2d97700 caused a major regression for us, in that it appears --include-dev-deps was never wired through, and maven test dependencies are therefore included by default. Will it be fixed in this PR? IMO it's worthy of a hotfix as we had to downgrade to stop all of our builds producing hundreds of test CVEs |
|
Thanks @DmitriyLewen , with the PR it doesn't scan test dependencies by default any more. |
9 tasks
DmitriyLewen
commented
Sep 12, 2024
Comment on lines
+32
to
+34
| if isIntegrationTestDir(filePath) && !a.includeDevDeps { | ||
| return nil, nil | ||
| } |
There was a problem hiding this comment.
I was thinking about moving this check to the Required function.
But it might not be entirely obvious
7 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move dev(test) dependencies inclusion/exclusion in analyzers.
See #7476 for more details.
Related issues
Checklist