Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both is.safari() and is.chrome() returns true for facebook inapp browser #296

Open
bedis-elacheche opened this issue Sep 21, 2018 · 2 comments · May be fixed by #300
Open

Both is.safari() and is.chrome() returns true for facebook inapp browser #296

bedis-elacheche opened this issue Sep 21, 2018 · 2 comments · May be fixed by #300

Comments

@bedis-elacheche
Copy link

Hi,
I got an issue with browser detection features.
I used the following user agent string: Mozilla/5.0 (Linux; Android 7.0; SM-G930F Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/67.0.3396.87 Mobile Safari/537.36 [FB_IAB/FB4A;FBAV;]

Both methods is.safari() and is.chrome() are returing true for the same user agent.

@fslone-nomi
Copy link
Contributor

@bedis-elacheche Yeah currently both of those methods are using User Agent sniffing and aren't very reliable. I'll work on improving it and submit a pull request, in the meantime you'll have to depend on duck typing to make it more reliable.

@pikilipita
Copy link

That would be a great addition,
the same issue is happening within Skype mobile app:
it's tough to find out if a page it open within Skype inapp browser or within a real browser.

@bedis-elacheche bedis-elacheche linked a pull request Mar 27, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants