Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tom 256 #941

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add tom 256 #941

wants to merge 3 commits into from

Conversation

ineiti
Copy link

@ineiti ineiti commented Feb 21, 2025

Description

Add the Tom-256 curve from https://eprint.iacr.org/2021/1183 and described in https://neuromancer.sk/std/other/Tom-256

closes: #923

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@ineiti ineiti requested review from a team as code owners February 21, 2025 15:14
@ineiti ineiti requested review from Pratyush, mmagician and weikengchen and removed request for a team February 21, 2025 15:14
z-tech
z-tech reviewed Feb 26, 2025
View reviewed changes
devbox.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here?

z-tech
z-tech reviewed Feb 26, 2025
View reviewed changes
devbox.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here?

@z-tech

This comment was marked as outdated.

Sign in to view
@z-tech
Copy link
Contributor

z-tech commented Feb 27, 2025

@ineiti the error you see is fixed in this PR: #946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-tech z-tech z-tech left review comments

@Pratyush Pratyush Awaiting requested review from Pratyush Pratyush is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tom-256 curve
3 participants
@ineiti @z-tech @lovesh