Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KZG10::open and friends visibility #152

Closed
4 tasks
skaunov opened this issue Aug 17, 2024 · 2 comments · Fixed by #153
Closed
4 tasks

KZG10::open and friends visibility #152

skaunov opened this issue Aug 17, 2024 · 2 comments · Fixed by #153

Comments

@skaunov
Copy link
Contributor

skaunov commented Aug 17, 2024 •
edited
Loading

Summary

Streamline visibility in mod kzg: currently it offers entities which can be obtained only from other modules which is confusing.

Problem Definition

fn open... are pub(crate) and it seems like it's the only way to get Proof in kzg10; of course, it is used in other modules, but it makes disentangling that thing quite confusing.

Proposal

Either pub those functions from kzg, either pub use entities from kzg in modules where they can actually be obtained and pub(crate) them in kzg.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Pratyush
Copy link
Member

Thanks for noticing this papercut! Making the methods pub would be fine; would you like to make a PR?

@skaunov
Copy link
Contributor Author

skaunov commented Aug 26, 2024

Yep! Just wasn't sure which path was better, now that's clear.

@skaunov skaunov mentioned this issue Aug 27, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 25, 2024
@skaunov @Pratyush
Resolve #152 (#153)
bbdb37e 
* Resolve #152

(Plus minor docs formatting.)

* add the changelog entry

* fixing unrelated lint

---------

Co-authored-by: Pratyush Mishra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #152
2 participants
@Pratyush @skaunov