Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying of Django custom URL from Django Sites #512

Open
plq opened this issue Oct 6, 2016 · 5 comments
Open

Allow specifying of Django custom URL from Django Sites #512

plq opened this issue Oct 6, 2016 · 5 comments

Comments

@plq
Copy link
Member

plq commented Oct 6, 2016

Continuation of #508
plq added a commit to plq/spyne that referenced this issue Oct 6, 2016
@plq
Allow specifying of Django custom URL from Django Sites arskom#508 ar…
d422bc8 
…skom#512
@plq
Copy link
Member Author

plq commented Oct 6, 2016

@felixcheruiyot what do you think about this patch? does it solve your problems?

plq added a commit to plq/spyne that referenced this issue Oct 6, 2016
@plq
Allow specifying of Django custom URL from Django Sites arskom#508 ar…
782d42c 
…skom#512
plq added a commit to plq/spyne that referenced this issue Oct 6, 2016
@plq
Allow specifying of Django custom URL from Django Sites arskom#508 ar…
9222a48 
…skom#512
@plq
Copy link
Member Author

plq commented Oct 6, 2016

The new branch for this patch is here: https://github.com/arskom/spyne/tree/django-custom-url

This seems to break a lot of django tests. Please fix them and let me know

@plq
Copy link
Member Author

plq commented Oct 6, 2016

fyi: https://travis-ci.org/arskom/spyne/jobs/165540568

@plq plq mentioned this issue Oct 7, 2016
Closed
@felixcheruiyot
Copy link

@plq I'll go through this and revert ASAP.

@plq
Copy link
Member Author

plq commented Oct 10, 2016

Thanks! You can create a new pull request (for this branch instead of
master) so the tests run for your commits as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plq @felixcheruiyot