Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use inspect.signature for decorators #539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use inspect.signature for decorators #539

wants to merge 1 commit into from

Conversation

costela
Copy link
Contributor

@costela costela commented Aug 12, 2017

fixes #538

@costela costela force-pushed the 538_support_other_decorators branch from 508e1d1 to 346c1d8 Compare August 12, 2017 12:48
@costela
Copy link
Contributor Author

costela commented Aug 12, 2017

This PR is not ideal. I originally overlooked the fact that inspect.signature is only available in py3 and py2's counterpart - inspect.getargspec - doesn't work with decorators.

I personally would still find it nice to have this working at least with py3, but this is of course not the perfect solution.

Another option would be using the decorator module, but this seems like overkill (especially since spyne's dependencies are so few; would be a shame to add one just for a fringe feature)

Any thoughts?

@costela costela mentioned this pull request Aug 14, 2017
Open
@plq plq added Enhancement Python3-Only Stuff that wouldn't work on python 2 labels Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Python3-Only Stuff that wouldn't work on python 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use inspect instead of f.__code__
2 participants
@costela @plq