Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Handle all up flags as role variables #408

Open
1 of 21 tasks
artis3n opened this issue Dec 24, 2023 · 1 comment
Open
1 of 21 tasks

[FEAT] Handle all up flags as role variables #408

artis3n opened this issue Dec 24, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@artis3n
Copy link
Owner

artis3n commented Dec 24, 2023

We're up to 3 or so exceptions to tailscale_args, where some flags are handled by dedicated variables in this role and most are not. This is confusing behavior. Originally, tailscale_args was set up this way because the Tailscale CLI was new and undergoing rapid development and there wasn't a guarantee that flags would be stable. This is no longer the case, and supporting all flags as arguments to this role would simplify usage and "Ansible-ize" the rest of the parameters.

Edit July 2024, starting on this:

Please comment on this issue and get sign-off from @artis3n before making PRs for any of these flags. I have an idea how I want this to work and I welcome contributions for it, but I don't want you to waste effort!

Flags that will become input variables to this role:

  • --accept-dns. Possible values: true/false
  • --accept-risk. Possible values: "lose-ssh", "all", or ""
  • --advertise-exit-node. Possible values: true/false
  • --advertise-routes. Values will be a list<string> and each input will be validated as valid CIDR syntax.
  • --advertise-tags. Values will be a list<string>.
  • --authkey. Already a dedicated variable.
  • --exit-node. Value will be a string, and can be an empty string to disable a previously set configuration.
  • --exit-node-allow-lan-access. Possible values: true/false
  • --force-reauth. Possible values: true/false
  • --hostname. Value will be a string.
  • --login-server. Value will be a string.
  • --netfilter-mode. Possible values: "off", "nodivert", "on".
  • --operator. Value will be a string. Value must be an existing Linux user on the target, or the role will fail.
  • --qr. Won't be supported by this role.
  • --reset. Possible values: true/false
  • --shields-up. Possible values: true/false
  • --snat-subnet-routes. Possible values: true/false
  • --stateful-filtering. Possible values: true/false
  • --ssh. Possible values: true/false
  • --timeout. Value will be an integer representing time in seconds.
  • --unattended. Windows-only, so won't be supported by this role.
@artis3n artis3n changed the title [FEAT] Handle all up flags as module variables [FEAT] Handle all up flags as role variables Dec 24, 2023
@artis3n artis3n added the enhancement New feature or request label Jan 21, 2024
@artis3n artis3n self-assigned this Apr 13, 2024
@artis3n artis3n pinned this issue Jul 7, 2024
@artis3n
Copy link
Owner Author

artis3n commented Jul 7, 2024

Going to start thinking about this more actively. Collected current list of flags from https://tailscale.com/kb/1241/tailscale-up in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant