Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add basehub support #147

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add basehub support #147

wants to merge 7 commits into from

Conversation

julianbenegas
Copy link

No description provided.

@julianbenegas julianbenegas changed the title add basehub support feat: add basehub support Nov 19, 2024
@matiasperz
Copy link

🔼 upvote

ascorbic
ascorbic approved these changes Nov 20, 2024
View reviewed changes
Copy link
Owner

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

ascorbic
ascorbic requested changes Nov 20, 2024
View reviewed changes
Copy link
Owner

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, can you update the tests. It looks like the expected URLs are wrong. There are instructions in the contributing guide to running them locally

@julianbenegas
Copy link
Author

Ah, can you update the tests. It looks like the expected URLs are wrong. There are instructions in the contributing guide to running them locally

Fixed! Still not 100% sure of when fit=cover should be set. I think it'll be fine for most cases though.

@julianbenegas
Copy link
Author

hey @ascorbic, i fixed the tests here eb12cd5 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic Awaiting requested review from ascorbic

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianbenegas @matiasperz @ascorbic