{cmake} Don't force warnings as errors when building self (#299)

Fixes #279

Author: asmaloney

.github/workflows/build.yml

@@ -161,6 +161,7 @@ jobs:
           -DE57_BUILD_SHARED=${{ matrix.build_shared }}
           -DE57_BUILD_TEST=${{ matrix.build_test }}
           -DE57_VALIDATION_LEVEL=${{ matrix.validation_level }}
+          -DE57FORMAT_WARNING_AS_ERROR:BOOL=ON
           -DE57FORMAT_SANITIZE_ALL:BOOL=ON
           .
 

CMakeLists.txt

@@ -162,12 +162,6 @@ target_compile_features( ${PROJECT_NAME}
 # Warnings
 include( CompilerWarnings )
 
-# Treat warnings as errors if we are building ourself.
-if ( E57_BUILDING_SELF )
-    unset( ${PROJECT_NAME_UPPERCASE}_WARNING_AS_ERROR CACHE )
-    set_warning_as_error()
-endif()
-
 # Check our validation level
 string( STRIP "${E57_VALIDATION_LEVEL}" E57_VALIDATION_LEVEL )
 if ( NOT E57_VALIDATION_LEVEL MATCHES "^[0-2]$" )