MAINT: adding deprecation for the removed argument

Author: bsipocz

astroquery/gaia/core.py

@@ -27,6 +27,7 @@
 from astropy.io import votable
 from astropy.table import Table
 from astropy.units import Quantity
+from astropy.utils.decorators import deprecated_renamed_argument
 from requests import HTTPError
 
 from astroquery import log
@@ -167,9 +168,11 @@ def logout(self, *, verbose=False):
         except HTTPError:
             log.error("Error logging out data server")
 
+    @deprecated_renamed_argument("output_file", None, since="0.4.8")
     def load_data(self, ids, *, data_release=None, data_structure='INDIVIDUAL', retrieval_type="ALL",
                   linking_parameter='SOURCE_ID', valid_data=False, band=None, avoid_datatype_check=False,
-                  format="votable", dump_to_file=False, overwrite_output_file=False, verbose=False):
+                  format="votable", dump_to_file=False, overwrite_output_file=False, verbose=False,
+                  output_file=None):
         """Loads the specified table
         TAP+ only
 

astroquery/gaia/tests/test_gaiatap.py

@@ -26,6 +26,7 @@
 from astropy.coordinates.sky_coordinate import SkyCoord
 from astropy.table import Column, Table
 from astropy.utils.data import get_pkg_data_filename
+from astropy.utils.exceptions import AstropyDeprecationWarning
 from requests import HTTPError
 
 from astroquery.gaia import conf
@@ -1022,14 +1023,18 @@ def load_data_monkeypatched(self, params_dict, output_file, verbose):
 
     monkeypatch.setattr(TapPlus, "load_data", load_data_monkeypatched)
 
-    GAIA_QUERIER.load_data(
-        valid_data=True,
-        ids="1,2,3,4",
-        format='votable',
-        retrieval_type="epoch_photometry",
-        verbose=True,
-        dump_to_file=True,
-        overwrite_output_file=True)
+    # Keep the tests, just remove the argument once the deprecation is removed
+    with pytest.warns(AstropyDeprecationWarning,
+                      match='"output_file" was deprecated in version 0.4.8'):
+        GAIA_QUERIER.load_data(
+            valid_data=True,
+            ids="1,2,3,4",
+            format='votable',
+            retrieval_type="epoch_photometry",
+            verbose=True,
+            dump_to_file=True,
+            overwrite_output_file=True,
+            output_file=tmp_path / "output_file")
 
     path.unlink()