Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equation references are wrong #1

Open
Overv opened this issue May 10, 2017 · 0 comments
Open

Equation references are wrong #1

Overv opened this issue May 10, 2017 · 0 comments

Comments

@Overv
Copy link

Overv commented May 10, 2017

The equation references in the code appear to be referring to an old version of the paper. For example, this line references an equation with a sigma:

https://github.com/atilimcetin/guided-filter/blob/master/guidedfilter.cpp#L133

However, equation 14 in the final paper does not have a sigma in it:

http://kaiminghe.com/publications/pami12guidedfilter.pdf

I think the code means to reference equation 19 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant