Add 'IdentifierRegistry' mechanism for debugging IDs

Whenever an ID is generated, we will optionally log it to a file with the data used to generate it. This will help us debug generated identifiers on artefacts or runtime errors. Test Plan: N/A Pull Request: #333
atlassian-labs · Feb 6, 2025 · 4c3ae4c · 4c3ae4c
1 parent da1500b
commit 4c3ae4c
Show file tree

Hide file tree

Showing 5 changed files with 60 additions and 11 deletions.
diff --git a/packages/core/core/src/Dependency.js b/packages/core/core/src/Dependency.js
@@ -20,6 +20,7 @@ import {
 import {toInternalSourceLocation} from './utils';
 import {toProjectPath} from './projectPath';
 import assert from 'assert';
+import {identifierRegistry} from './IdentifierRegistry';
 
 type DependencyOpts = {|
   id?: string,
@@ -80,7 +81,9 @@ export function createDependencyId({
     priority: priority ? Priority[priority] : Priority.sync,
     packageConditions,
   };
-  return createDependencyIdRust(params);
+  const id = createDependencyIdRust(params);
+  identifierRegistry.addIdentifier('dependency', id, params);
+  return id;
 }
 
 export function createDependency(

diff --git a/packages/core/core/src/Environment.js b/packages/core/core/src/Environment.js
@@ -9,6 +9,7 @@ import {createEnvironmentId} from '@atlaspack/rust';
 import {toInternalSourceLocation} from './utils';
 import PublicEnvironment from './public/Environment';
 import {environmentToInternalEnvironment} from './public/Environment';
+import {identifierRegistry} from './IdentifierRegistry';
 
 const DEFAULT_ENGINES = {
   browsers: ['> 0.25%'],
@@ -137,7 +138,7 @@ export function mergeEnvironments(
 }
 
 function getEnvironmentHash(env: Environment): string {
-  return createEnvironmentId({
+  const data = {
     context: env.context,
     engines: env.engines,
     includeNodeModules: env.includeNodeModules,
@@ -147,5 +148,8 @@ function getEnvironmentHash(env: Environment): string {
     shouldOptimize: env.shouldOptimize,
     shouldScopeHoist: env.shouldScopeHoist,
     sourceMap: env.sourceMap,
-  });
+  };
+  const id = createEnvironmentId(data);
+  identifierRegistry.addIdentifier('environment', id, data);
+  return id;
 }
diff --git a/packages/core/core/src/IdentifierRegistry.js b/packages/core/core/src/IdentifierRegistry.js
@@ -0,0 +1,20 @@
+// @flow strict-local
+
+import fs from 'fs';
+
+export class IdentifierRegistry {
+  constructor() {}
+
+  addIdentifier(type: string, identifier: string, data: mixed) {
+    if (process.env.ATLASPACK_IDENTIFIER_DEBUG === 'true') {
+      fs.appendFile(
+        './atlaspack-identifiers.txt',
+        // $FlowFixMe
+        `${type} ${identifier} ${JSON.stringify(data)}\n`,
+        () => {},
+      );
+    }
+  }
+}
+
+export const identifierRegistry: IdentifierRegistry = new IdentifierRegistry();
diff --git a/packages/core/core/src/assetUtils.js b/packages/core/core/src/assetUtils.js
@@ -39,6 +39,7 @@ import {
 import {hashString, createAssetId as createAssetIdRust} from '@atlaspack/rust';
 import {BundleBehavior as BundleBehaviorMap} from './types';
 import {PluginTracer} from '@atlaspack/profiler';
+import {identifierRegistry} from './IdentifierRegistry';
 
 export type AssetOptions = {|
   id?: string,
@@ -69,15 +70,18 @@ export type AssetOptions = {|
 |};
 
 export function createAssetIdFromOptions(options: AssetOptions): string {
-  return createAssetIdRust({
+  const data = {
     environmentId: options.env.id,
     filePath: options.filePath,
     code: options.code,
     pipeline: options.pipeline,
     query: options.query,
     uniqueKey: options.uniqueKey,
     fileType: options.type,
-  });
+  };
+  const id = createAssetIdRust(data);
+  identifierRegistry.addIdentifier('asset', id, data);
+  return id;
 }
 
 export function createAsset(

diff --git a/packages/core/core/src/public/MutableBundleGraph.js b/packages/core/core/src/public/MutableBundleGraph.js
@@ -30,6 +30,24 @@ import {HASH_REF_PREFIX} from '../constants';
 import {fromProjectPathRelative} from '../projectPath';
 import {BundleBehavior} from '../types';
 import BundleGroup, {bundleGroupToInternalBundleGroup} from './BundleGroup';
+import type {ProjectPath} from '../projectPath';
+import {identifierRegistry} from '../IdentifierRegistry';
+
+function createBundleId(data: {|
+  entryAssetId: string | null,
+  uniqueKey: string | null,
+  distDir: ProjectPath,
+  bundleBehavior: string | null,
+|}): string {
+  const {entryAssetId, uniqueKey, distDir, bundleBehavior} = data;
+  const id = hashString(
+    `bundle:${String(
+      entryAssetId != null ? entryAssetId : uniqueKey,
+    )}${fromProjectPathRelative(distDir)}${bundleBehavior ?? ''}`,
+  );
+  identifierRegistry.addIdentifier('bundle', id, data);
+  return id;
+}
 
 export default class MutableBundleGraph
   extends BundleGraph<IBundle>
@@ -181,12 +199,12 @@ export default class MutableBundleGraph
       : null;
 
     let target = targetToInternalTarget(opts.target);
-    let bundleId = hashString(
-      'bundle:' +
-        (opts.entryAsset ? opts.entryAsset.id : opts.uniqueKey) +
-        fromProjectPathRelative(target.distDir) +
-        (opts.bundleBehavior ?? ''),
-    );
+    let bundleId = createBundleId({
+      entryAssetId: entryAsset?.id ?? null,
+      uniqueKey: opts.uniqueKey ?? null,
+      distDir: target.distDir,
+      bundleBehavior: opts.bundleBehavior ?? null,
+    });
 
     let existing = this.#graph._graph.getNodeByContentKey(bundleId);
     if (existing != null) {