method to return actual flag value

atlassian-labs · Feb 21, 2025 · e7a2eaf · e7a2eaf
1 parent d8bbec9
commit e7a2eaf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/core/feature-flags/src/index.js b/packages/core/feature-flags/src/index.js
@@ -28,6 +28,12 @@ export function getFeatureFlag(flagName: $Keys<FeatureFlags>): boolean {
   return value === true || value === 'NEW';
 }
 
+export function getFeatureFlagValue(
+  flagName: $Keys<FeatureFlags>,
+): boolean | string | number {
+  return featureFlagValues[flagName];
+}
+
 export type DiffResult<CustomDiagnostic> = {|
   isDifferent: boolean,
   custom: CustomDiagnostic,

diff --git a/packages/core/fs/src/NodeVCSAwareFS.js b/packages/core/fs/src/NodeVCSAwareFS.js
@@ -7,7 +7,7 @@ import type {FilePath} from '@atlaspack/types-internal';
 import type {Event, Options as WatcherOptions} from '@parcel/watcher';
 import {registerSerializableClass} from '@atlaspack/build-cache';
 import {instrument, instrumentAsync} from '@atlaspack/logger';
-import {getFeatureFlag} from '@atlaspack/feature-flags';
+import {getFeatureFlagValue} from '@atlaspack/feature-flags';
 
 // $FlowFixMe
 import packageJSON from '../package.json';
@@ -45,15 +45,15 @@ export class NodeVCSAwareFS extends NodeFS {
       type: e.changeType,
     }));
 
-    if (getFeatureFlag('vcsMode') !== 'NEW') {
+    if (getFeatureFlagValue('vcsMode') !== 'NEW') {
       watcherEventsSince = await instrumentAsync(
         'NodeVCSAwareFS::watchman.getEventsSince',
         () => this.watcher().getEventsSince(dir, nativeSnapshotPath, opts),
       );
       this.#options.logEventDiff(watcherEventsSince, vcsEventsSince);
     }
 
-    if (['NEW_AND_CHECK', 'NEW'].includes(getFeatureFlag('vcsMode'))) {
+    if (['NEW_AND_CHECK', 'NEW'].includes(getFeatureFlagValue('vcsMode'))) {
       return vcsEventsSince;
     }
 
@@ -71,7 +71,7 @@ export class NodeVCSAwareFS extends NodeFS {
       snapshotDirectory,
       `${filename}.native-snapshot.txt`,
     );
-    if (getFeatureFlag('vcsMode') !== 'NEW') {
+    if (getFeatureFlagValue('vcsMode') !== 'NEW') {
       await this.watcher().writeSnapshot(dir, nativeSnapshotPath, opts);
     }