Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sinon flow bindings #325

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

yamadapc
Copy link
Contributor

@yamadapc yamadapc commented Feb 5, 2025

Fixes flow type bindings so that further refinement assertions can be built
with typechecking.

For example, this is currently failing to typecheck:

const writeFileSync = sinon.stub(fs, 'writeFileSync');
const count = writeFileSync.withArgs('f', 'contents').callCount;

And will typecheck now.

Test Plan: yarn flow

Created using spr 1.3.5
@yamadapc yamadapc requested a review from a team February 5, 2025 04:30
@yamadapc yamadapc enabled auto-merge (squash) February 5, 2025 04:31
@yamadapc yamadapc disabled auto-merge February 5, 2025 06:25
@yamadapc yamadapc merged commit 0b6aa9e into main Feb 5, 2025
17 checks passed
@yamadapc yamadapc deleted the spr/yamadapc/fix-sinon-flow-bindings-1 branch February 5, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants