Add dominance algorithm implementation #326
Merged
+318
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
yamadapc
added a commit
that referenced
this pull request
Feb 5, 2025
Implements "A simple, fast dominance algorithm", to find the immediate dominators of all nodes in a graph. - https://www.cs.tufts.edu/comp/150FP/archive/keith-cooper/dom14.pdf This will be used for a new experimental bundler package to be added. This adds the empty package. Test Plan: Run `yarn test` to execute unit-tests for the implementation Pull Request: #326
|
|
||
| import assert from 'assert'; | ||
| import {ContentGraph} from '@atlaspack/graph'; | ||
| import {simpleFastDominance} from '../../../src/DominatorBundler/findAssetDominators/simpleFastDominance'; |
There was a problem hiding this comment.
Any reason you're using a test folder instead of placing it with the source?
There was a problem hiding this comment.
What do you mean?
Do you mean using
- /src
- /test
?
That's just how the repository is setup. I'd rather colocate the tests.
There was a problem hiding this comment.
Yeah, colocation. Be the change...
There was a problem hiding this comment.
I think we could do that for the entire repository separately (?)
...s/bundler-experimental/test/DominatorBundler/findAssetDominators/simpleFastDominance.test.js
Outdated
Show resolved
Hide resolved
MonicaOlejniczak
approved these changes
Feb 6, 2025
Created using spr 1.3.5
yamadapc
deleted the
spr/yamadapc/add-dominance-algorithm-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements "A simple, fast dominance algorithm", to find the immediate
dominators of all nodes in a graph.
This will be used for a new experimental bundler package to be added.
This adds the empty package.
Test Plan: Run
yarn testto execute unit-tests for the implementation