Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional fixes after testing in product #328

Closed
wants to merge 1 commit into from
Closed

additional fixes after testing in product #328

wants to merge 1 commit into from

Conversation

pancaspe87
Copy link
Contributor

Following previous PR, we are now extending option type to also include the build event. This will allow us to track other data such as the duration of the build

yamadapc
yamadapc requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@yamadapc yamadapc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need for this change

It doesn't make sense to pass in a value into a construct then read it back like this

@pancaspe87 pancaspe87 closed this Feb 5, 2025
@pancaspe87 pancaspe87 deleted the vcs-fixes-2 branch February 6, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamadapc yamadapc yamadapc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pancaspe87 @yamadapc