Add graph that can store edge weights #329
Merged
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
yamadapc
added a commit
that referenced
this pull request
Feb 5, 2025
Add a content graph class that can store edge weights, rather than just node weights Test Plan: yarn test Pull Request: #329
yamadapc
added a commit
that referenced
this pull request
Feb 6, 2025
Add a content graph class that can store edge weights, rather than just node weights Test Plan: yarn test Pull Request: #329
| assert.deepEqual(clonedGraph.nodes, graph.nodes); | ||
| assert.deepEqual(clonedGraph.getAllEdges(), graph.getAllEdges()); | ||
| assert.equal(clonedGraph.getEdgeWeight(a, b), weight1); | ||
| assert.equal(clonedGraph.getEdgeWeight(b, c), weight2); |
There was a problem hiding this comment.
maybe assert that clonedGraph is not the same instance as graph and that adding to clonedGraph does not impact graph
MonicaOlejniczak
approved these changes
Feb 6, 2025
yamadapc
deleted the
spr/yamadapc/add-graph-that-can-store-edge-weights
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a content graph class that can store edge weights, rather than just node weights
Test Plan: yarn test