Add (tracing) metrics around VCS calls #336
Merged
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
| @@ -4,6 +4,7 @@ import invariant from 'assert'; | |||
|
|
|||
| import ThrowableDiagnostic from '@atlaspack/diagnostic'; | |||
| import type {Async} from '@atlaspack/types'; | |||
| import {instrument} from '@atlaspack/logger'; | |||
There was a problem hiding this comment.
How come you opted for re-using the logger package as opposed to a tracing package? They seem discrete enough to me, but let me know what you think.
There was a problem hiding this comment.
Hey, I thought because tracing::... is just one back-end (generally), and we will likely want to integrate JS and Rust logging/tracing back-ends, we could use the same package for now.
yamadapc
added a commit
that referenced
this pull request
Feb 12, 2025
Test Plan: N/A Pull Request: #336
yamadapc
added a commit
that referenced
this pull request
Feb 12, 2025
Test Plan: N/A Pull Request: #336
JakeLane
approved these changes
Feb 12, 2025
pancaspe87
approved these changes
Feb 12, 2025
yamadapc
deleted the
spr/yamadapc/add-tracing-metrics-around-vcs-calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan: N/A