-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cache invalidation to report build type #339
Update cache invalidation to report build type #339
Conversation
Created using spr 1.3.5
🦋 Changeset detectedLatest commit: 0d92935 The changes in this PR will be included in the next version bump. This PR includes changesets to release 125 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Created using spr 1.3.5
'@atlaspack/service-worker': minor | ||
'@atlaspack/ts-utils': minor | ||
'@atlaspack/validator-eslint': minor | ||
'@atlaspack/validator-typescript': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come we're bumping every package? Can't we just release core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned this earlier, I'm not sure but I reckon also changes to core do impact everything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changesets should take care of it if core is listed as an explicit dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I believe changesets will bump all packages because they have explicit dependencies with one another and core is depended on by everything.
Created using spr 1.3.5
Created using spr 1.3.5
We would want to track the initial cache invalidation differently from other
cache invalidation events.
Test Plan: N/A