Fix error masking when errors occur in the bundle graph request #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d72abfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yamadapc
approved these changes
Feb 14, 2025
| @@ -6455,4 +6455,40 @@ describe('scope hoisting', function () { | |||
| }, | |||
| ]); | |||
| }); | |||
|
|
|||
| // This is currently failing due to dependency.sourceAssetId becoming stale | |||
There was a problem hiding this comment.
it started failing with this change?
There was a problem hiding this comment.
No, I discovered it from a support request. I'm making a ticket to track the fix separately but thought it was worth committing the repro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prior to this change, if an error occurred during parts of the bundle graph request, the error would be hidden due to the
finallyblock throwing an error attempting to create a graphviz file for the graph. This is optional behaviour, exclusively used for internal debugging so it's safe to opt out of.Changes
BundleGraph.fromAssetGraphedge caseChecklist