Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exiting async function spans #342

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

yamadapc
Copy link
Contributor

The tracer wasn't ending these async function spans properly.

This is of limited use at the moment because async functions might overlap, so
the spans won't be quite right as is.

Test Plan: N/A

Created using spr 1.3.5
Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 4f40009

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 98 packages
Name Type
@atlaspack/logger Patch
@atlaspack/bundler-experimental Patch
@atlaspack/cache Patch
@atlaspack/cli Patch
@atlaspack/core Patch
@atlaspack/fs Patch
@atlaspack/package-manager Patch
@atlaspack/utils Patch
@atlaspack/workers Patch
@atlaspack/watcher-watchman-js Patch
@atlaspack/test-utils Patch
@atlaspack/query Patch
@atlaspack/register Patch
@atlaspack/bundle-stats Patch
@atlaspack/reporter-bundle-stats Patch
@atlaspack/transformer-html Patch
@atlaspack/link Patch
@atlaspack/node-resolver-core Patch
@atlaspack/bundler-default Patch
@atlaspack/optimizer-blob-url Patch
@atlaspack/optimizer-css Patch
@atlaspack/optimizer-data-url Patch
@atlaspack/optimizer-image Patch
@atlaspack/optimizer-svgo Patch
@atlaspack/optimizer-swc Patch
@atlaspack/optimizer-terser Patch
@atlaspack/packager-css Patch
@atlaspack/packager-html Patch
@atlaspack/packager-js Patch
@atlaspack/packager-raw-url Patch
@atlaspack/packager-svg Patch
@atlaspack/packager-webextension Patch
@atlaspack/packager-xml Patch
@atlaspack/reporter-build-metrics Patch
@atlaspack/reporter-bundle-analyzer Patch
@atlaspack/reporter-cli Patch
@atlaspack/reporter-dev-server-sw Patch
@atlaspack/reporter-dev-server Patch
@atlaspack/reporter-json Patch
@atlaspack/reporter-lsp Patch
@atlaspack/reporter-sourcemap-visualiser Patch
@atlaspack/reporter-tracer Patch
@atlaspack/resolver-glob Patch
@atlaspack/runtime-browser-hmr Patch
@atlaspack/runtime-js Patch
@atlaspack/runtime-react-refresh Patch
@atlaspack/runtime-service-worker Patch
@atlaspack/runtime-webextension Patch
@atlaspack/transformer-babel Patch
@atlaspack/transformer-css Patch
@atlaspack/transformer-image Patch
@atlaspack/transformer-js Patch
@atlaspack/transformer-postcss Patch
@atlaspack/transformer-posthtml Patch
@atlaspack/transformer-react-refresh-wrap Patch
@atlaspack/transformer-typescript-types Patch
@atlaspack/transformer-webextension Patch
@atlaspack/transformer-webmanifest Patch
@atlaspack/validator-eslint Patch
@atlaspack/validator-typescript Patch
@atlaspack/types Patch
@atlaspack/resolver-default Patch
@atlaspack/config-default Patch
@atlaspack/config-repl Patch
@atlaspack/config-webextension Patch
@atlaspack/plugin Patch
@atlaspack/optimizer-inline-requires Patch
@atlaspack/transformer-jsonld Patch
@atlaspack/bundler-library Patch
@atlaspack/compressor-brotli Patch
@atlaspack/compressor-gzip Patch
@atlaspack/compressor-raw Patch
@atlaspack/namer-default Patch
@atlaspack/optimizer-cssnano Patch
@atlaspack/optimizer-htmlnano Patch
@atlaspack/packager-raw Patch
@atlaspack/packager-ts Patch
@atlaspack/packager-wasm Patch
@atlaspack/reporter-bundle-buddy Patch
@atlaspack/reporter-conditional-manifest Patch
@atlaspack/resolver-repl-runtimes Patch
@atlaspack/transformer-glsl Patch
@atlaspack/transformer-graphql Patch
@atlaspack/transformer-inline-string Patch
@atlaspack/transformer-inline Patch
@atlaspack/transformer-json Patch
@atlaspack/transformer-less Patch
@atlaspack/transformer-mdx Patch
@atlaspack/transformer-pug Patch
@atlaspack/transformer-raw Patch
@atlaspack/transformer-sass Patch
@atlaspack/transformer-svg-react Patch
@atlaspack/transformer-svg Patch
@atlaspack/transformer-toml Patch
@atlaspack/transformer-typescript-tsc Patch
@atlaspack/transformer-worklet Patch
@atlaspack/transformer-xml Patch
@atlaspack/transformer-yaml Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Created using spr 1.3.5
yamadapc added a commit that referenced this pull request Feb 17, 2025
The tracer wasn't ending these async function spans properly.

This is of limited use at the moment because async functions might overlap, so
the spans won't be quite right as is.

Test Plan: N/A

Pull Request: #342
@yamadapc yamadapc requested a review from a team February 17, 2025 23:50
@yamadapc yamadapc merged commit 3005307 into main Feb 18, 2025
18 checks passed
@yamadapc yamadapc deleted the spr/yamadapc/fix-exiting-async-function-spans branch February 18, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants