Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exiting async function spans #342

Merged
merged 2 commits into from
Feb 18, 2025
+8 −2
Merged

Fix exiting async function spans #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cd2007
[𝘀𝗽𝗿] initial version
yamadapc Feb 17, 2025
4f40009
add changeset
yamadapc Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tall-impalas-suffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@atlaspack/logger': patch
---

Fix exiting async spans on instrumentAsync
5 changes: 3 additions & 2 deletions packages/core/logger/src/tracer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ export async function instrumentAsync<T>(
fn: () => Promise<T>,
): Promise<T> {
const span = tracer.enter(label);
let result;
try {
const result = await fn();
return result;
result = await fn();
} finally {
tracer.exit(span);
}
return result;
}