Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specific event types from vcs fs #345

Merged
merged 4 commits into from
Feb 19, 2025
Merged

Support specific event types from vcs fs #345

merged 4 commits into from
Feb 19, 2025

Conversation

yamadapc
Copy link
Contributor

Adds support for VCS change lists to differentiate between create/delete/update
events.

Test Plan: cargo test

@yamadapc
[𝘀𝗽𝗿] initial version
7901553 
Created using spr 1.3.5
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 91a6001

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yamadapc yamadapc requested review from pancaspe87 and a team February 18, 2025 23:57
@yamadapc
fix build/test errors
38e7a92 
Created using spr 1.3.5
yamadapc added a commit that referenced this pull request Feb 19, 2025
@yamadapc
Support specific event types from vcs fs
0db95f9 
Adds support for VCS change lists to differentiate between create/delete/update
events.

Test Plan: cargo test

Pull Request: #345
@yamadapc
Fix compilation
91a6001 
Created using spr 1.3.5
yamadapc added a commit that referenced this pull request Feb 19, 2025
@yamadapc
Support specific event types from vcs fs
d9ef333 
Adds support for VCS change lists to differentiate between create/delete/update
events.

Test Plan: cargo test

Pull Request: #345
pancaspe87
pancaspe87 reviewed Feb 19, 2025
View reviewed changes
crates/atlaspack_vcs/src/lib.rs

changed_files.push(FileChangeEvent {
path: new_file_path,
change_type: match status {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all of these types for our solution? Do they affect how we bundle things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do at the moment, but we might tweak the invalidation routine a bit to handle full node_modules sub-directory invalidation

@yamadapc
update PR
0d21df8 
Created using spr 1.3.5
@yamadapc yamadapc merged commit 0c3ad7a into main Feb 19, 2025
18 checks passed
@yamadapc yamadapc deleted the spr/yamadapc/support-specific-event-types-from-vcs-fs branch February 19, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pancaspe87 pancaspe87 pancaspe87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamadapc @pancaspe87