Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper dev scripts #347

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Helper dev scripts #347

merged 2 commits into from
Feb 21, 2025

Conversation

alshdavid
Copy link
Contributor

A script with a few commands I run frequently

./scripts/dev build
./scripts/dev watch

Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: c8fa09a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yamadapc
Copy link
Contributor

yamadapc commented Feb 19, 2025

Shouldn't we put these in package.json though?

@alshdavid alshdavid merged commit cbcb436 into main Feb 21, 2025
18 checks passed
@alshdavid alshdavid deleted the alsh/dev-script branch February 21, 2025 01:09
@alshdavid
Copy link
Contributor Author

alshdavid commented Feb 21, 2025

Shouldn't we put these in package.json though?

I find the package.json#scripts not to be the best place to house multi-step, multi-line or cross platform build tasks. Personally I'd prefer it if we used a task runner like just or make. Could also just use bash but that has cross-platform problems.

I'd like to revisit our build process and task runner sometime soon when there's bandwidth for it, perhaps after a migration to TypeScript (which would simplify the build process to begin with)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants