Issue/vcs toggle vcs modes #352
Merged
+45
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bba2fe6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 99 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pancaspe87
commented
Feb 21, 2025
| @@ -27,6 +28,12 @@ export function getFeatureFlag(flagName: $Keys<FeatureFlags>): boolean { | |||
| return value === true || value === 'NEW'; | |||
| } | |||
|
|
|||
| export function getFeatureFlagValue( | |||
There was a problem hiding this comment.
@yamadapc we can't use the existing getFeatureFlag as we need to differentiate between NEW_AND_CHECK and NEW
yamadapc
approved these changes
Feb 21, 2025
pancaspe87
force-pushed
the
issue/vcs-toggle-vcs-modes
branch
from
77962ce to
e7a2eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to implement a consistency check pattern to enable VCS modes under a feature flag. There are 4 different scenarios that will be controlled by combining a 'killswitch', already implemented in product, and a flag to toggle the relevant mode, as explains below:
The first 2 modes are already available in the products and are switched on/off by an infra ff. This PR introduces the ability to return different values for the last 2 modes through another infra ff.